Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce component test for KeptnTaskDefinition controller #988

Merged
merged 2 commits into from
Mar 7, 2023
Merged

test: introduce component test for KeptnTaskDefinition controller #988

merged 2 commits into from
Mar 7, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Mar 7, 2023

Part of: #320

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 3930280
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64070bb99300f50008cb9819
😎 Deploy Preview https://deploy-preview-988--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: odubajDT <[email protected]>
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #988 (3cf1d65) into main (444ba74) will increase coverage by 0.38%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   57.38%   57.77%   +0.38%     
==========================================
  Files         119      122       +3     
  Lines        9914    10095     +181     
==========================================
+ Hits         5689     5832     +143     
- Misses       4027     4054      +27     
- Partials      198      209      +11     
Impacted Files Coverage Δ
...ptnworkloadinstance/reconcile_prepostdeployment.go 81.81% <0.00%> (-9.10%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 54.94% <0.00%> (-3.30%) ⬇️
...ollers/lifecycle/keptntaskdefinition/controller.go 92.00% <0.00%> (ø)
...ifecycle/keptntaskdefinition/reconcile_function.go 72.72% <0.00%> (ø)
.../controllers/lifecycle/keptnworkload/controller.go 67.08% <0.00%> (ø)
operator/controllers/common/evaluationhandler.go 79.71% <0.00%> (+2.17%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 81.16% <0.00%> (+2.24%) ⬆️
...ptnworkloadinstance/reconcile_prepostevaluation.go 90.90% <0.00%> (+18.18%) ⬆️
...or/controllers/lifecycle/interfaces/eventobject.go 100.00% <0.00%> (+37.50%) ⬆️
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 52.37% <ø> (+2.92%) ⬆️
lifecycle-operator 53.63% <ø> (ø)
metrics-operator 62.98% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review March 7, 2023 10:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@odubajDT odubajDT merged commit 0eef9b0 into keptn:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants